Clarify scipy linprog transformation description#742
Clarify scipy linprog transformation description#742Zhengyizhe0209-arch wants to merge 1 commit into
Conversation
Clarifies that SciPy transforms the problem into standard form internally after presolve.
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Many thanks @Zhengyizhe0209-arch! It's a nice PR. I think the wording should be a bit more specific because the lecture calls In SciPy, Because of this, I would avoid saying that SciPy necessarily converts the problem to standard form by adding slack variables before solving, since that description is mainly tied to the legacy I think this is also the point that is being raised in #599. A simpler replacement could be:
Another small comment: you noted that this PR addresses #599, but it only tackles the first part of the issue. It would be nice to address the entire issue in one PR or explicitly state that it addresses the first or second part of the issue to avoid closing it without fully resolving it. |
Addresses #599.
This PR makes the description of
scipy.optimize.linprogmore precise by noting that SciPy transforms the problem into standard form internally after presolve.